Feature : SEND_LOGS_TO_TIMBER env variable to enable or disable timber logging
#1933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er logging (in development.rb)
…er logging (in production.rb)
PicoCreator
changed the title
SEND_LOGS_TO_TIMBER env variable to enable or disable timber loggingSEND_LOGS_TO_TIMBER env variable to enable or disable timber logging
pr-triage
bot
removed
the
PR: unreviewed
4 tasks
benhalpern
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Yeah this would work. We could bikeshed over the prettiest way to do this but I'm cool with this. @maestromac merge if you're happy.
PicoCreator
changed the title
SEND_LOGS_TO_TIMBER env variable to enable or disable timber loggingSEND_LOGS_TO_TIMBER env variable to enable or disable timber logging
pr-triage
bot
added
the
PR: reviewed-approved
|
Ok - removed WIP title |
pr-triage
bot
added
PR: merged
PicoCreator
deleted the
feature/env-variable-to-enable-or-disable-timber-logging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Added the
SEND_LOGS_TO_TIMBERenvironment variable with false/true default for dev/production modes.This allows configuration disabling of TIMBER - in "production" mode.
PS : Im not a ruby dev - so someone should really double check before merging
Related Tickets & Documents
#1844 - to streamline production mode for docker build
Added to documentation?
[optional] What gif best describes how it makes you feel?