-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Display comment published timestamp according to user's locale #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rhymes As for the async jobs: maybe you haven't run them for a long time, and the jobs just kept adding? (just for the clarification) |
Thanks for providing a separate |
@lightalloy it's totally possible :D I "fixed it" by deleting all the jobs from PostgreSQL, fresh start.
Yeah me too, I wonder if there's a "plan" to slowly migrate those files to either Preact or ES6. I'll take a look at the failed tests :) |
I think deleting is a good enough solution in your case ) I haven't heard of any plan for migration to es6 yet 👀, but that would be cool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work once again @rhymes !
What type of PR is this? (check all applicable)
Description
This PR does two main things:
comment-date
tagIt contains a few additional things:
I've moved
.eslintrc.js
from the main folder toapp/assets/javascripts
and set the correct ECMA version. The reason is that my VS Code kept complaining the code wasn't ES2016, which it isn't, it's ECMA 5. The folder with the "modern" JavaScript isapp/javascript
and it already has its own ESLint configuration file.I've deleted
app/assets/javascripts/utilities/getLocalTime.js
because it wasn't used anywhere and it contained a duplicate function already contained inside initializeTimeFixer.jsA note: I couldn't test it with the "reading list -> comment activity" comments because I'm swamped by async jobs that are taking forever. If anybody has suggestions about what to do with those (beside delete them) please let me know. This is my current situation locally:
Related Tickets & Documents
Closes #406
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
This is how it looks if I set my browser to Italian for example:
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?