Skip to content

Conversation

mariocsee
Copy link
Contributor

@mariocsee mariocsee commented Apr 16, 2019

What type of PR is this?

  • Refactor

Description

  • Gives users the ability to change your inbox type between private and open in /settings/misc.
  • Added message when clicking on Block in Connect that explains that block is only implemented in connect and not all throughout DEV.

Related Tickets & Documents

continues off #1563 and #2074
resolves #1567

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

/settings/misc

Screen Shot 2019-04-16 at 15 48 56

New Message Modal

Screen Shot 2019-04-16 at 15 47 39

/connect

Screen Shot 2019-04-16 at 15 47 54

Additional Clarification

Screen Shot 2019-04-16 at 15 48 22

Added to documentation?

  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 16, 2019
@mariocsee mariocsee self-assigned this Apr 16, 2019
@mariocsee mariocsee changed the title Release Open Inbox [WIP] Release Open Inbox Apr 16, 2019
@pr-triage pr-triage bot removed the PR: unreviewed bot applied label for PR's with no review label Apr 16, 2019
@mariocsee mariocsee changed the title [WIP] Release Open Inbox Release Open Inbox Apr 16, 2019
@mariocsee mariocsee requested a review from benhalpern April 16, 2019 20:37
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 16, 2019
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 17, 2019
@benhalpern benhalpern merged commit dd78c5e into forem:master Apr 17, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 17, 2019
@benhalpern
Copy link
Contributor

Alright @mariocsee it is going live. I'm going to make some additional PRs to fiddle with certain elements of this but excited to have it go up!

coreyja added a commit to coreyja/dev.to that referenced this pull request Apr 20, 2019
* master: (83 commits)
  Update gitdocs (forem#2500)
  Condense 'ask me anything' to 'ama' (forem#2428) [ci skip]
  Add user_signed_in? to cache key for styles (forem#2498)
  Added troubleshooting for byebug without readline issue (forem#2481)
  Fix some frontend linting issues (forem#2495) [ci skip]
  Fix <br/> in footer. (forem#2491)
  Remove extra param and add message for prefill (forem#2487)
  Make Cards Change Dynamically and add Reader/Follower Charts (forem#2488)
  Temporarily comment out random (forem#2486)
  Add nav buttons to pwa desktop (forem#2484)
  Feature/filtered charts (forem#2482)
  Add caching for historical data (forem#2476)
  There are installation sections for other OSes now. (forem#2480)
  Add inbox guidelines to users (forem#2473)
  Release Open Inbox (forem#2468)
  Convert underscores in article slugs properly (forem#2472)
  Update framework defaults to match those in Rails 5.1 (forem#2309)
  Enable random order for specs (forem#2466) [ci skip]
  forem#118 Allow users to embed Medium posts with Liquid Tags (forem#1161)
  Allow API to return top articles (forem#2469)
  ...

# Conflicts:
#	Envfile
#	app/models/user.rb
#	db/schema.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
2 participants