Skip to content

Remove unused gem fake_stripe #2517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2019
Merged

Remove unused gem fake_stripe #2517

merged 1 commit into from
Apr 22, 2019

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Apr 22, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

I can't find a place where the gem fake_stripe is used, it has likely been completely replaced by stripe-ruby-mock but left behind.

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Apr 22, 2019
maestromac
maestromac approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Apr 22, 2019
@maestromac maestromac merged commit 197e7cb into forem:master Apr 22, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Apr 22, 2019
@rhymes rhymes deleted the rhymes/remove-fake_stripe branch April 22, 2019 16:36
@weekly-digest weekly-digest bot mentioned this pull request Apr 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@maestromac maestromac maestromac approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhymes @maestromac