Skip to content

Fix flaky editor spec & change dev configs #3022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 3, 2019
Merged

Fix flaky editor spec & change dev configs #3022

merged 5 commits into from
Jun 3, 2019

Conversation

maestromac
Copy link
Contributor

@maestromac maestromac commented Jun 1, 2019 •
edited
Loading

What type of PR is this? (check all applicable)

  • Misc

Description

Aside from fixing test:

  • I downgraded factory_bot_rails as it is interferring with spring workflow.
  • Simplecov is configured to be disabled by default. Simply adding COVERAGE=true will enable it.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • no documentation needed

@weekly-digest weekly-digest bot mentioned this pull request Jun 3, 2019
Closed
@maestromac maestromac changed the title [WIP] Fix flaky test Fix flaky test Jun 3, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 3, 2019
@maestromac maestromac changed the title Fix flaky test Fix flaky editor spec & change dev configs Jun 3, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 3, 2019
@benhalpern benhalpern merged commit cea7766 into forem:master Jun 3, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 3, 2019
@maestromac maestromac deleted the mac/spec/fix-flaky-test branch June 3, 2019 19:13
@rhymes
Copy link
Contributor

rhymes commented Jun 6, 2019

@maestromac what's let_it_be ? Love the creativity of the DSL designers though :D

@maestromac
Copy link
Contributor Author

@rhymes It's like a before(:all) but without the need of manual database cleaning. The doc is here. Using it help reduce race condition errors in test. I can't thoroughly explain why it works but I've stressed test it by running those specs 50 times.

@weekly-digest weekly-digest bot mentioned this pull request Jun 10, 2019
Closed
@brarnaudovski brarnaudovski mentioned this pull request Jul 24, 2019
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maestromac @rhymes @benhalpern