Add a space between "Change meta tag" and canonical_url #3063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the space, this shows up as "Change meta tagcanonical_url".
|
|
|
Hi @danielcompton , thanks for the PR, if you sign the CLA you're good to go :) |
|
Done! |
rhymes
approved these changes
Jun 7, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Without the space between these two elements, this shows up as Change meta tag
canonical_url.Related Tickets & Documents
prettier/prettier#4223 (comment) describes how composing JSX elements over multiple lines needs
{' '}.Mobile & Desktop Screenshots/Recordings (if there are UI changes)
I haven't actually tried this myself, but I saw the before image at https://www.cdevn.com/why-medium-actually-sucks/:
and looking at the code, I could see why it looked that way, and what to do to fix it.
Added to documentation?