Fix js-breaking webcomponent #3087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
reviewed
Jun 9, 2019
| @@ -1 +1,10 @@ | |||
| import 'clipboard-copy-element'; | |||
| document.addEventListener('DOMContentLoaded', () => { | |||
| const waitingForOnboarding = setInterval(() => { | |||
There was a problem hiding this comment.
question: why did you wrap it in a set interval? doesn't it already "wait" ? I'm looking at the example you mentioned here https://github.com/webcomponents/webcomponentsjs/#asynchronous
There was a problem hiding this comment.
Thanks for pointing that out. I've tried so many things but I forgot to try the most obvious one 😆. I updated it and it seems to be working too.
There was a problem hiding this comment.
I now remember why, Waterfox doesn't seem to acknowledge the waitfor method.
benhalpern
approved these changes
Jun 10, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
pr-triage
bot
added
PR: reviewed-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
It seems that having a standalone copy of
webcomponent-loader.jsis both insufficient and breaking JS on some browser, particularly WaterFox. WebComponent's suggestion to use polyfill is in the follow manner:but that also is not a viable option since we can't load dependency from node-module like that. The next best thing we can do is asynchronously load the polyfill from the CDN based this instruction. The README stated that the loader is efficient and will load only what is necessary.
I have tried to not rely on CDN by letting webpack dynamically import it but that also doesn't seem to work without additional webpack configuration. If there's a more viable solution or I missed something, please let me know.
Related Tickets & Documents
#3081 and quite possibly some users on #2790
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
n/a
Added to documentation?