Destroy organization memberships if user is destroyed #3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhao-Andy
commented
Jun 11, 2019
| it "destroys associated organization memberships" do | ||
| organization_membership = create(:organization_membership, user_id: user.id, organization_id: org.id) | ||
| user.destroy | ||
| expect { organization_membership.reload }.to raise_error ActiveRecord::RecordNotFound |
There was a problem hiding this comment.
I had to use this workaround instead of organization_membership.persisted? since .persisted? kept returning true for some reason.
benhalpern
approved these changes
Jun 11, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fixes a minor bug where a user's organization memberships were not destroyed when the user was destroyed.
Related #3077