use dynamic route name #3147
Merged
use dynamic route name #3147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
awcodify
reviewed
Jun 18, 2019
app/controllers/users_controller.rb
Outdated
| @@ -6,7 +6,7 @@ class UsersController < ApplicationController | |||
| def edit | |||
| unless current_user | |||
| skip_authorization | |||
| return redirect_to "/enter" | |||
| return redirect_to new_user_registration_path_path | |||
There was a problem hiding this comment.
can we also change the alias into new_user_registration_path in routes? If it too much effort, let's stick with this one.
There was a problem hiding this comment.
new_user_registration_path has already been declared by devise. What else do you reckon? :)
awcodify
previously approved these changes
Jun 20, 2019
pr-triage
bot
added
PR: reviewed-approved
maestromac
suggested changes
Jun 24, 2019
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
that is a good suggestion |
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
redirect_toinusers_controller.rbwas using a hardcoded route path, so I just changed it to using a dynamic route name pathAdded to documentation?