Skip to content

Update RssReader's liquid & youtube parsing logic #3229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 20, 2019
Merged

Update RssReader's liquid & youtube parsing logic #3229

merged 5 commits into from
Jun 20, 2019

Conversation

maestromac
Copy link
Contributor

@maestromac maestromac commented Jun 18, 2019 •
edited
Loading

What type of PR is this? (check all applicable)

  • Bug Fix

Description

  • Pre-escape {{ }} expression that is breaking MarkdownParser with backtick.
  • Loosen up RssReader's youtube id parsing logic.

Related Tickets & Documents

#3070

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 18, 2019
@maestromac maestromac changed the title Loosen up Liquid::Variable [WIP] Loosen up Liquid::Variable Jun 18, 2019
@pr-triage pr-triage bot removed the PR: unreviewed bot applied label for PR's with no review label Jun 18, 2019
@maestromac maestromac changed the title [WIP] Loosen up Liquid::Variable Update RssReader's liquid & youtube parsing logic Jun 19, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 19, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 20, 2019
@benhalpern benhalpern merged commit 8ec4e33 into forem:master Jun 20, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 20, 2019
@maestromac maestromac deleted the mac/bug/rss-liquid-variable-issue branch June 20, 2019 19:27
@maestromac maestromac mentioned this pull request Jun 20, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Jun 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

@Zhao-Andy Zhao-Andy Awaiting requested review from Zhao-Andy

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maestromac @benhalpern