Fixed rubocop issues, new .rubocop_todo.yml #3255
Conversation
| - 'app/models/article.rb' | ||
|
|
||
| # Offense count: 2101 | ||
| # Offense count: 2415 |
There was a problem hiding this comment.
ahhaha this keeps increasing :D
| if params[:config] == "all_comments" && current_user_is_author? | ||
| @notification_subscription.notifiable.update(receive_notifications: true) | ||
| end | ||
| @notification_subscription.notifiable.update(receive_notifications: true) if params[:config] == "all_comments" && current_user_is_author? |
There was a problem hiding this comment.
I'm not a mega fan of the giant ifs at the end, i think the code was more readable before. I'm thinking we should not enforce this, what do you think?
There was a problem hiding this comment.
Agree, I haven't checked the autocorrected stuff properly.
| 'Content-Type': 'application/json', | ||
| }, | ||
| body: JSON.stringify({poll_vote: { poll_option_id: optionId } }), | ||
| body: JSON.stringify({poll_skip: {poll_id: pollId }}), |
There was a problem hiding this comment.
should this be part of this PR? It seems it's changing behavior here
There was a problem hiding this comment.
It's poll_skip and poll_id in master:
https://github.com/thepracticaldev/dev.to/blob/e46bd26223847e35b9de2cd57380bad12a97286f/app/liquid_tags/poll_tag.rb#L96
I wonder why it shows the changes.
There was a problem hiding this comment.
It's weird, have you tried to rebase?
There was a problem hiding this comment.
Yep, "up-to-date".
There was a problem hiding this comment.
It happened to me once or twice, what I did was to create a new branch, cherry pick the commits from the old one in order and either force push or create a new PR.
I still don't know why :(
There was a problem hiding this comment.
BTW the second commit contains the change so cherry picking it won't work e2f6837
There was a problem hiding this comment.
Actually, if you look at line 81 red and green - they are identical, and the line 96 red and green - they are identical as well (apart from the indentation).
But the git diff looks confusing.
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
What type of PR is this? (check all applicable)
Description
.rubocop_todo.yml