Optimization: Remove cached_followed_tag_names From Async User Data #8148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
pr-triage
bot
added
PR: unreviewed
mstruve
changed the title
nickytonline
approved these changes
May 29, 2020
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
base_data in our AsyncInfo Controller is above and beyond our most hit route(see purple line on the graph below) so it should be as lean and mean as possible. I noticed that we were using two calls and different methods to return tags and their names when one would suffice. I removed the tag names and added a little snippet so our javascript can parse them out itself.
CodeClimate is not a fan of removing code. It can be ignored in this case.
Added tests?