Repository navigation
Replies: 2 comments
|
Thanks for asking first, and for keeping it small! I'd rather keep cameras out of the core and have them as a plugin. A plugin hook for taps is the way I'd like to go: if you send a PR with the hooks you need (a tap handler for a device kind, plus whatever the live window and the wedge need from the view), kept generic and with tests, I'm happy to take it. Your camera and alarm plugin can then live in its own repository, and I'll link it from the README. |
0 replies
|
Small change of plan: I went ahead and built it myself, along the lines you described, so you don't need to send anything.
If you try it on your tablet, I'd love to hear how it does, and if you miss something from your version, a PR against the plugin is very welcome. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi! Since NextFloor is in daily use on our wall tablet, the one thing we really missed is the cameras, so we brought a smaller version back in our own copy. Before opening anything, I'd like to ask: you removed cameras on purpose in 0.8.0 – would you take them back in a reduced form, or would you rather keep them out of NextFloor?
What we have, built on the code you removed (
c605f8e) and kept small:picture-entitywithcamera_view: live, so WebRTC/HLS through go2rtc, MJPEG as a fallback). ✕ or a second tap closes it, ⤢ opens HA's big dialog. Card optioncamera_popup: corner | dialog.Not brought back: the camera wall, flying into the picture, the motion trail and the detection pins.
If you're open to it, I'd send it as one PR with small separate commits (camera kind and live window, alarm, wedge settings, tilt, detections), each with tests, and the texts in German, English and French. If you'd rather not have cameras in the core, would a plugin hook for taps be an option, so this could live as a plugin? Either answer is fine with us.
All reactions