Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit\Event\Test\PassedButRisky #32

Closed
3 tasks done
localheinz opened this issue Aug 7, 2020 · 1 comment
Closed
3 tasks done

PHPUnit\Event\Test\PassedButRisky #32

localheinz opened this issue Aug 7, 2020 · 1 comment
Assignees
Labels
enhancement event: clarify emit location Need to clarify where to emit event event: compose data Event object needs to compose data

Comments

@localheinz
Copy link
Collaborator

localheinz commented Aug 7, 2020

  • emit where?
  • test class, test method, data provider set?
  • reason (e.g., no assertions, missing @uses annotation?)

Related to #1.

@localheinz localheinz added event: compose data Event object needs to compose data event: clarify emit location Need to clarify where to emit event labels Aug 7, 2020
@localheinz localheinz changed the title PHPUnit\Event\Test\RunRisky PHPUnit\Event\Test\PassedButRisky Sep 4, 2020
@localheinz localheinz mentioned this issue Sep 11, 2020
41 tasks
@localheinz localheinz self-assigned this Nov 7, 2020
@localheinz localheinz assigned localheinz and unassigned localheinz Nov 7, 2020
@localheinz
Copy link
Collaborator Author

@sebastianbergmann @theseer

I'm unsure where to emit the event, but we can take a look on Monday!

👀

localheinz added a commit that referenced this issue Jan 29, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Feb 1, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Feb 7, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Feb 12, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Feb 12, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Feb 14, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Feb 16, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Feb 24, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Mar 6, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Mar 14, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue Apr 2, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
localheinz added a commit that referenced this issue May 21, 2021
Fixes #32.

Co-authored-by: Andreas Möller <am@localheinz.com>
Co-authored-by: Arne Blankerts <Arne@Blankerts.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement event: clarify emit location Need to clarify where to emit event event: compose data Event object needs to compose data
Projects
None yet
Development

No branches or pull requests

1 participant