Working draft for Event subsystem

[localheinz]

This PR

• proposes an even sub-system for phpunit

Build Status

[rpkamp]

This seems prone to collision with other types.
Maybe change to get_class($other) === get_class($this) && $other->asString() === $this->asString()?

Note that in PHP the object has access to the $name property of $other since it's in the same class, so this would also work:

return get_class($other) === get_class($this) && $other->name === $this->name;

[theseer]

As this class will vanish (see below), this point is probably mute.

Regarding property access: Yes, we are aware of that but I consider it bad software design. The asString is part of the public API, the existence of the property name is a (private) implementation detail.

[rpkamp]

I would add the class name of the subscriber here to create a bit of context: Event subscriber "Foo\Bar\BazSubscriber" does not support events of type "blah"

[theseer]

Good idea.

Even though this should technically be almost impossible to ever trigger, given that the dispatcher uses the same method to find out what types of events to send to this subscriber.

[localheinz]

Good point, thank you, @rpkamp!

[rpkamp]

Really awesome that you're implementing this 👍 🚀

[codecov-io]

Codecov Report

Merging #1 into master will increase coverage by 0.61%.
The diff coverage is 91.39%.

@@             Coverage Diff              @@
##             master       #1      +/-   ##
============================================
+ Coverage     83.56%   84.18%   +0.61%     
- Complexity     4501     4733     +232     
============================================
  Files           218      260      +42     
  Lines         11030    11745     +715     
============================================
+ Hits           9217     9887     +670     
- Misses         1813     1858      +45

Impacted Files	Coverage Δ	Complexity Δ
src/TextUI/Configuration/PHPUnit/Extension.php	100% <ø> (+29.78%)	6 <0> (-11)	⬇️
src/Event/GlobalState/Restored.php	100% <100%> (ø)	2 <2> (?)
src/Event/Test/TearDownFinished.php	100% <100%> (ø)	2 <2> (?)
src/Event/GlobalState/Captured.php	100% <100%> (ø)	2 <2> (?)
src/Event/Test/RunFailed.php	100% <100%> (ø)	7 <7> (?)
src/Event/Telemetry/MemoryUsage.php	100% <100%> (ø)	4 <4> (?)
src/Event/Facade.php	100% <100%> (ø)	8 <8> (?)
src/Event/Test/RunWarning.php	100% <100%> (ø)	7 <7> (?)
src/Event/Comparator/Registered.php	100% <100%> (ø)	2 <2> (?)
src/Event/Telemetry/Snapshot.php	100% <100%> (ø)	4 <4> (?)
... and 83 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e1cf3...3e7e63f. Read the comment docs.

[theseer]

This PR is closed as it was merged by other means.