Skip to content

fix: correct bug where commands hang on windows when retrieving stdout/stderr #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 6, 2024

Conversation

brianheineman
Copy link
Contributor

@brianheineman brianheineman commented Jul 5, 2024

Fixes #99

@github-actions github-actions bot added the fix Bug fix label Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🐰Bencher

ReportSat, July 6, 2024 at 02:37:41 UTC
Projecttheseus-rs/postgresql-embedded
Branchcorrect-windows-hang
Testbedlocalhost

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
extract➖ (view plot)154,060.00
lifecycle➖ (view plot)1,231,000,000.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.58%. Comparing base (480faa8) to head (5e5aac0).

Files Patch % Lines
postgresql_commands/src/traits.rs 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   99.56%   99.58%   +0.02%     
==========================================
  Files          78       78              
  Lines        8638     8583      -55     
==========================================
- Hits         8600     8547      -53     
+ Misses         38       36       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brianheineman brianheineman merged commit d472022 into main Jul 6, 2024
@brianheineman brianheineman deleted the correct-windows-hang branch July 6, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start process doesn't gets completed in windows
1 participant