Fix Custom Release URL Not Working and Compilation Failure

[YageGeng]

1. Set function postgresql_archive::configuration::theseus::matcher::matcher as the default matcher​
2. ​​Register the default matcher for the custom URL​

[YageGeng]

Hi @brianheineman ,​​
You can test this issue using the custom repo here: https://github.com/AtomInnoLab/postgresql-binaries. Feel free to provide any feedback or suggestions—I welcome all critiques and improvements!

Thanks in advance for your help!

[brianheineman]

Hello @YageGeng, thank you for reporting the error and submitting a PR. As far as the implementation goes, I would prefer to see the matcher in a new module that is a sibling to the theseus and zonky modules under configuration, I largely try to avoid putting code into mod.rs. Also, in bundle.rs I think that should be refactored to avoid the need for a CUSTOM_REPO_URL LazyLock, and instead just pass an Option<&str> into fn register_github_repository(url: Option<&str>) -> Result<()>; if a url is passed in, register the matcher for it which should avoid the need for passing the url via CUSTOM_REPO_URL.

[YageGeng]

Hi @brianheineman ,
Thank you for the feedback! I agree with your suggestions and will work on addressing them as soon as possible. I’ll push the updates ​​within the next few days​​.
I'll make sure to notify you as soon as the changes are ready for review. I appreciate your patience!

[YageGeng]

@brianheineman Hi, I update the code. I found to register a matcher, must be a pure function.
If pass a closure, and a non-static variable is captured. the the closure will be an anonymous structure. This will cause type mismatch errors.
so. i change the SupportsFn type to support.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.97%. Comparing base (39a9206) to head (f5401a0).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files          71       72    +1     
  Lines        9785     9803   +18     
=======================================
+ Hits         9685     9703   +18     
  Misses        100      100           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[brianheineman]

@YageGeng thank you for the submission! I made a few changes in order to reinstate the SupportsFn type and to register the custom/theseus matchers conditionally.

[brianheineman]

@YageGeng these changes were released in 0.18.5