fix interpolation order #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elbehery95
force-pushed
the
interpolation_256_fix
branch
from
b29a227
to
e5327fa
Compare
add interpolation order test
bbc2
force-pushed
the
interpolation_256_fix
branch
from
e5327fa
to
df530fb
Compare
|
Thank you! I've updated the commit with minor changes. |
transcranial
added a commit
to transcranial/python-dotenv
that referenced
this pull request
Jul 13, 2020
bbc2
pushed a commit
that referenced
this pull request
Jul 17, 2020
johnbergvall
pushed a commit
to johnbergvall/python-dotenv
that referenced
this pull request
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #256 when users refer to an environment variable that is defined at the current environment and re-defined at the file, the interpolation order always favors the os.environ value.
It does not make sense to favor the environment variable as it is already re-defined in the .env file context. This PR reverts the order of getting these values from the proper dicts. Also i have added a test case to expose such behavior