Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MTL] [BUG] Under Recovery boot ~ 45 seconds is taken for "MTL DSP init fail" #4565

Closed
RDharageswari opened this issue Aug 31, 2023 · 4 comments
Closed

[MTL] [BUG] Under Recovery boot ~ 45 seconds is taken for "MTL DSP init fail" #4565

RDharageswari opened this issue Aug 31, 2023 · 4 comments
Assignees
@ranj063 @RDharageswari
Labels
MTL Applies to Meteor Lake platform.

Comments

@RDharageswari
Copy link

RDharageswari commented Aug 31, 2023 •
edited
Loading

the kernel should not spend ~ 45 seconds traversing an error path we expect in the recovery boot case. can we teach the kernel to handle this case more efficiently?
PS: Audio is not expected to work in recovery boot followed by cold reset and this is working as expected with the current design

68.673585] init: cros-camera main process ended, respawning
[ 73.126044] mtk_t7xx 0000:58:00.0: Port AT is not opened, drop packets
[ 74.201174] sof-audio-pci-intel-mtl 0000:00:1f.3: ------------[ DSP dump start ]------------
[ 74.210639] sof-audio-pci-intel-mtl 0000:00:1f.3: MTL DSP init fail
[ 74.217665] sof-audio-pci-intel-mtl 0000:00:1f.3: fw_state: SOF_FW_BOOT_IN_PROGRESS (3)
[ 74.226633] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM status: 0xffffffff, ROM error: 0xffffffff
[ 74.236363] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM debug status: 0x80000009, ROM debug error: 0x48
[ 74.246676] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM feature bit not enabled
[ 74.254657] sof-audio-pci-intel-mtl 0000:00:1f.3: ------------[ DSP dump end ]------------
[ 74.546635] init: cros-camera main process (5642) terminated with status 1
[ 74.554380] init: cros-camera main process ended, respawning
[ 80.458539] init: cros-camera main process (5697) terminated with status 1
[ 80.466436] init: cros-camera main process ended, respawning
[ 86.360121] init: cros-camera main process (5757) terminated with status 1
[ 86.368002] init: cros-camera main process ended, respawning
[ 92.256658] init: cros-camera main process (5803) terminated with status 1
[ 92.264427] init: cros-camera main process ended, respawning
[ 94.266167] sof-audio-pci-intel-mtl 0000:00:1f.3: MTL DSP init fail
[ 98.121020] init: cros-camera main process (5854) terminated with status 1
[ 98.128798] init: cros-camera main process ended, respawning
[ 103.980570] init: cros-camera main process (5900) terminated with status 1
[ 103.988475] init: cros-camera main process ended, respawning
[ 109.883095] init: cros-camera main process (5954) terminated with status 1
[ 109.890992] init: cros-camera main process ended, respawning
[ 114.275667] sof-audio-pci-intel-mtl 0000:00:1f.3: timeout waiting for purge IPC done
[ 114.284350] sof-audio-pci-intel-mtl 0000:00:1f.3: MTL DSP init fail
@RDharageswari RDharageswari added the MTL Applies to Meteor Lake platform. label Aug 31, 2023
ranj063 added a commit to ranj063/linux that referenced this issue Sep 7, 2023
@ranj063
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
66cac62 
20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s to address this issue.

Link: thesofproject#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063 ranj063 mentioned this issue Sep 7, 2023
Merged
@RDharageswari
Copy link
Author

verified the patch and it looks good, fixes the issue.
Validation WIP

@RDharageswari
Copy link
Author

RDharageswari commented Sep 9, 2023 •
edited
Loading

Logs:
[ 99.853113] sof-audio-pci-intel-mtl 0000:00:1f.3: -----------[ DSP dump start ]-----------
[ 99.862564] sof-audio-pci-intel-mtl 0000:00:1f.3: MTL DSP init fail
[ 99.869589] sof-audio-pci-intel-mtl 0000:00:1f.3: fw_state: SOF_FW_BOOT_IN_PROGRESS (3)
[ 99.878544] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM status: 0xffffffff, ROM error: 0xffffffff
[ 99.888269] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM debug status: 0x80000009, ROM debug error: 0x48
[ 99.898577] sof-audio-pci-intel-mtl 0000:00:1f.3: ROM feature bit not enabled
[ 99.906548] sof-audio-pci-intel-mtl 0000:00:1f.3: -----------[ DSP dump end ]-----------
[ 100.418106] sof-audio-pci-intel-mtl 0000:00:1f.3: MTL DSP init fail
[ 100.927591] sof-audio-pci-intel-mtl 0000:00:1f.3: timeout waiting for purge IPC done
[ 100.936276] sof-audio-pci-intel-mtl 0000:00:1f.3: MTL DSP init fail
[ 100.944325] sof-audio-pci-intel-mtl 0000:00:1f.3: error: dsp init failed after 3 attempts with err: -110
[ 100.954950] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to start DSP
[ 100.962145] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed to boot DSP firmware -110
[ 100.972906] sof-audio-pci-intel-mtl 0000:00:1f.3: error: sof_probe_work failed err: -110

ranj063 added a commit to ranj063/linux that referenced this issue Sep 12, 2023
@ranj063
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
309d53b 
20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ujfalusi pushed a commit that referenced this issue Sep 13, 2023
@ranj063 @ujfalusi
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
cffcac3 
20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: #4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ujfalusi pushed a commit that referenced this issue Sep 14, 2023
@ranj063 @ujfalusi
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
1be4e38 
20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: #4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 17, 2023
@ranj063 @broonie
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
e0f9624 
20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
mj22226 pushed a commit to mj22226/linux that referenced this issue Oct 4, 2023
@ranj063 @gregkh
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
a9b59d4 
[ Upstream commit e0f9624 ]

20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Kaz205 pushed a commit to Kaz205/linux that referenced this issue Oct 5, 2023
@ranj063 @gregkh
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
217a80a 
[ Upstream commit e0f9624 ]

20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Oct 6, 2023
@ranj063 @gregkh
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
633f356 
[ Upstream commit e0f9624 ]

20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject/linux#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Whissi pushed a commit to Whissi/linux-stable that referenced this issue Oct 6, 2023
@ranj063 @gregkh
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
ee8bbb2 
[ Upstream commit e0f9624 ]

20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject/linux#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
@keqiaozhang
Copy link
Collaborator

@RDharageswari, is this still a bug to you? No updates for a long time.

sileshn pushed a commit to sileshn/ubuntu-kernel-lunar that referenced this issue Dec 20, 2023
@ranj063 @smb49
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
e17d71d 
BugLink: https://bugs.launchpad.net/bugs/2046197

[ Upstream commit e0f96246c4402514acda040be19ee24c1619e01a ]

20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject/linux#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sileshn pushed a commit to sileshn/ubuntu-kernel-lunar that referenced this issue Jan 10, 2024
@ranj063 @roxanan1996
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
04fe472 
BugLink: https://bugs.launchpad.net/bugs/2046197

[ Upstream commit e0f96246c4402514acda040be19ee24c1619e01a ]

20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject/linux#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tuxedo-bot pushed a commit to tuxedocomputers/linux that referenced this issue Jan 17, 2024
@ranj063 @roxanan1996
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
373e3cf 
BugLink: https://bugs.launchpad.net/bugs/2044174

[ Upstream commit e0f9624 ]

20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject/linux#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>
@plbossart
Copy link
Member

closing, no input since september 2023. Please reopen if it's still a problem

paralin pushed a commit to skiffos/linux that referenced this issue Apr 14, 2024
@ranj063 @cristicc
ASoC: SOF: Intel: MTL: Reduce the DSP init timeout
fce6941 
20s seems unnecessarily large for the DSP init timeout. This coupled with
multiple FW boot attempts causes an excessive delay in the error path when
booting in recovery mode. Reduce it to 0.5s and use the existing
HDA_DSP_INIT_TIMEOUT_US.

Link: thesofproject#4565
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230915134153.9688-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
(cherry picked from commit e0f9624)
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ranj063 ranj063

@RDharageswari RDharageswari

Labels
MTL Applies to Meteor Lake platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@plbossart @ranj063 @keqiaozhang @RDharageswari