ngclient: remove sleep_before_round #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this config was to ensure blocking inside the download loop and releasing CPU resources. To our best knowledge the network stack currently used in RequestsFetcher will always block inside the loop and the issue cannot be reproduced. 'chunk_size' and 'socket_timeout' are currently the settings provided by RequestsFetcher to tweak CPU usage and download granularity. Signed-off-by: Teodora Sechkova <tsechkova@vmware.com>
Pull Request Test Coverage Report for Build 1316201048Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
jku
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1484
Description of the changes being introduced by the pull request:
The purpose of
sleep_before_roundwas to ensure blocking inside the download loop and releasing CPU resources.To our best knowledge the network stack currently used in RequestsFetcher will always block inside the loop
and the issue cannot be reproduced.
chunk_sizeandsocket_timeoutare currently the settings provided by RequestsFetcher to tweak CPU usage and download granularity.Please verify and check that the pull request fulfills the following
requirements: