Fix replace x.com with vxtwitter.com #6
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takurinton
changed the title
fix replace add description about x.com to README fix README Revert "fix replace" This reverts commit ad10018. fix format
takurinton
force-pushed
the
compatible-with-x-com
branch
from
57a5071 to
34f7671
Compare
takurinton
commented
Jun 3, 2024
| var modifiedLink = clipboardData.replace('twitter', 'vxtwitter'); | ||
| var modifiedLink = clipboardData.replace(/twitter\.com|x\.com/g, 'vxtwitter.com'); |
There was a problem hiding this comment.
If you replace x with vxtwitter, it may unintentionally hit characters in usernames, etc., so we include .com as well.
|
@takurinton Thanks for the contribution! Reviewed the changes and they look good. Merging this. |
thevenuz
approved these changes
Jun 3, 2024
|
@thevenuz |
|
@takurinton Hello. Published to the chrome store, so the changes should be reflected soon. |
thevenuz
added a commit
that referenced
this pull request
Aug 7, 2024
Fix replace x.com with vxtwitter.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5