-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are we sure we want to put all environment variables in our Repository settings? #2
Comments
I extracted it as a variable in case we want to test things on the staging first (e.g. deployment changes). That's what I did before this went live - set it to staging.worldcubeassociation.org It may make sense to make this env variable visible under settings (when adding an new one you can make it hidden or visible). |
jfly
added a commit
to jfly/wca-documents
that referenced
this issue
Sep 3, 2018
This fixes thewca#2
jfly
added a commit
to jfly/wca-documents
that referenced
this issue
Sep 3, 2018
This fixes thewca#2
Epride
added a commit
that referenced
this issue
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was trying to find out where
WCA_HOST
(used in deploy.sh) is defined, and it took me a while to find that it's defined over in https://travis-ci.org/thewca/wca-documents/settings. What's even weirder is that I can't actually see the value of the variable, it's just some dots:I'd argue that this is perfectly safe to put in our
.travis.yml
file.https://docs.travis-ci.com/user/environment-variables/ has some advice about where to put environment variables, and I feel like
$WCA_HOST
falls under the category of "if it does not contain sensitive information, might be different for different branches and should be available to forks – add it to your .travis.yml".The text was updated successfully, but these errors were encountered: