Cleanup claim condition extension classes #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquim-verges
changed the title
joaquim-verges
commented
Jun 7, 2022
| ///////////////////////////////////////////////////////////////////*/ | ||
|
|
||
| /// @dev Exposes the ability to override the msg sender. | ||
| function _dropMsgSender() internal virtual returns (address) { |
There was a problem hiding this comment.
only thing that's maybe a weird pattern is this. But saves us from inheriting ContextExecutable which adds burden for most ppl who don't use meta-tx.
let me know what you think @nkrishang @jakeloo
There was a problem hiding this comment.
yup this is similar to ERC721A pattern, maybe we can turn this into _thirdwebMsgSender() and we use it across the board or do you think this has to be isolated to each feature offering
There was a problem hiding this comment.
Pb is that it will clash if we declare it multiple times... So annoying. Hope solidity gets better overtime with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.