add modifier onlyOwner in Ownable #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /// @dev Returns the owner of the contract. | ||
| function owner() public view returns (address) { |
There was a problem hiding this comment.
if i remember correctly, owner is a standard that things like Opensea fetches, i think this should be fine, but we should make sure its still compatible? @jakeloo @nkrishang do you know?
| @@ -11,7 +11,20 @@ import "./interface/IOwnable.sol"; | |||
|
|
|||
| abstract contract Ownable is IOwnable { | |||
| /// @dev Owner of the contract (purpose: OpenSea compatibility) | |||
| address public override owner; | |||
| address private _owner; | |||
There was a problem hiding this comment.
i'm expecting to see a change in the interface as well but im not seeing it in this PR?
There was a problem hiding this comment.
Interface should remain the same. It has a function: owner(), which was previously overridden by the owner variable which was public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.