Skip to content

Change uint128 to uint256 in Staking721Base to maintain consistency #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Change uint128 to uint256 in Staking721Base to maintain consistency #307

merged 1 commit into from
Jan 18, 2023

Conversation

atharvadeosthale
Copy link
Contributor

@atharvadeosthale atharvadeosthale commented Jan 9, 2023 •
edited
Loading

In Staking20Base and Staking1155Base, the constructor params are uint256 but in Staking721Base it is uint128. In the docs it's mentioned uint256. I believe to maintain consistency this should be uint256

@kumaryash90 kumaryash90 merged commit c0a7d72 into thirdweb-dev:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atharvadeosthale @kumaryash90