Skip to content

Conversation

nkrishang
Copy link
Contributor

No description provided.

@nkrishang nkrishang changed the title Nkrishang/open nft collection Create OpenCollection ERC-721 Mar 24, 2023
}

/// @dev Returns whether lazy minting can be performed in the given execution context.
function _canLazyMint() internal view virtual returns (bool);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should probably be canSetSharedMetadata since we're referencing it as "Shared Metadata" everywhere

* @notice Lazy mint shared metadata
* @param _metadata common metadata for all tokens
*/
function lazyMintSharedMetadata(SharedMetadata calldata _metadata) external;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lazyMint or set?

'{"name": "',
name,
" ",
TWStrings.toString(tokenOfEdition),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we prepend #?

@nkrishang nkrishang changed the title Create OpenCollection ERC-721 Create OpenEdition ERC-721 May 1, 2023
@nkrishang nkrishang merged commit 92dca09 into main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants