-
Notifications
You must be signed in to change notification settings - Fork 564
Create OpenEdition ERC-721 #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
/// @dev Returns whether lazy minting can be performed in the given execution context. | ||
function _canLazyMint() internal view virtual returns (bool); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably be canSetSharedMetadata
since we're referencing it as "Shared Metadata" everywhere
* @notice Lazy mint shared metadata | ||
* @param _metadata common metadata for all tokens | ||
*/ | ||
function lazyMintSharedMetadata(SharedMetadata calldata _metadata) external; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lazyMint or set?
'{"name": "', | ||
name, | ||
" ", | ||
TWStrings.toString(tokenOfEdition), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we prepend #
?
No description provided.