Suggested Smart Account Changes

[ciaranightingale]

No description provided.

[joaquim-verges]

what does this do? is to prevent initializing the implementation itself?

isnt that already handled by the initializer modifier?

[nkrishang]

The _disableInitializer function has a different job than the initializer modifier.

You call the _disableInitializer function inside the constructor of the implementation smart contract instance to make sure that no one can call the initialize function on the implementation and mutate its state.

From reading the code -- calling _disableInitializer inside the implementation contract's constructor is a good practice and a recommendation in the code comments, but not doing this does not affect the proxy contracts that point at it.

Code comments for _disableInitializer:

    /**
     * @dev Locks the contract, preventing any future reinitialization. This cannot be part of an initializer call.
     * Calling this in the constructor of a contract will prevent that contract from being initialized or reinitialized
     * to any version. It is recommended to use this to lock implementation contracts that are designed to be called
     * through proxies.
     */

[joaquim-verges]

nice de-duping here, thanks for refactoring that