Skip to content

Remove DefaultOperatorFilterer #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 2, 2023

Conversation

WhiteOakKong
Copy link
Contributor

@WhiteOakKong WhiteOakKong commented Sep 27, 2023

Removal of DefaultOperatorFilterer from all contracts.

WhiteOakKong and others added 4 commits September 27, 2023 10:49
removed from all contracts except dynamic contracts.
Signed-off-by: WhiteOakKong <92236155+WhiteOakKong@users.noreply.github.com>
@WhiteOakKong WhiteOakKong marked this pull request as ready for review September 27, 2023 20:31
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
contracts/base/ERC1155Base.sol 86.20% <ø> (+5.56%) ⬆️
contracts/base/ERC1155Drop.sol 30.00% <ø> (+1.87%) ⬆️
contracts/base/ERC1155LazyMint.sol 41.17% <ø> (+4.33%) ⬆️
contracts/base/ERC721Base.sol 88.46% <ø> (+7.21%) ⬆️
contracts/base/ERC721Drop.sol 51.06% <ø> (+5.78%) ⬆️
contracts/base/ERC721LazyMint.sol 50.00% <ø> (+11.53%) ⬆️
contracts/base/ERC721Multiwrap.sol 31.03% <ø> (+5.32%) ⬆️
contracts/prebuilts/drop/DropERC1155.sol 45.31% <ø> (+3.88%) ⬆️
contracts/prebuilts/drop/DropERC721.sol 57.74% <ø> (+5.84%) ⬆️
contracts/prebuilts/loyalty/LoyaltyCard.sol 61.42% <ø> (+5.01%) ⬆️
... and 7 more

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@nkrishang nkrishang merged commit 6e260f2 into thirdweb-dev:main Oct 2, 2023
@1devNdogs
Copy link

Hello, I am wondering why this feature was removed from all contracts? I understand that this allowed us to enforce creators earning in secondary sales specifically in opensea, so now i dont have a way to do it.

@WhiteOakKong
Copy link
Contributor Author

Hello, I am wondering why this feature was removed from all contracts? I understand that this allowed us to enforce creators earning in secondary sales specifically in opensea, so now i dont have a way to do it.

It was removed because DefaultOperatorFilterer has been deprecated by opensea: https://opensea.io/blog/articles/creator-fees-update

@1devNdogs
Copy link

Hello, I am wondering why this feature was removed from all contracts? I understand that this allowed us to enforce creators earning in secondary sales specifically in opensea, so now i dont have a way to do it.

It was removed because DefaultOperatorFilterer has been deprecated by opensea: https://opensea.io/blog/articles/creator-fees-update

Thanks, just realized about the deprecation 15 minutes ago. Now it makes sense ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants