Skip to content

Smarter 1559 // Chain Utils // Caching #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Aug 9, 2024

PR-Codex overview

This PR focuses on enhancing wallet creation and transaction handling. It includes improvements in estimating gas fees, cache mechanisms, and EIP-155 enforcement checks.

Detailed summary

  • Added Console.WriteLine for wallet address
  • Improved gas fee estimation and handling
  • Implemented caching for chain data and EIP-155 enforcement checks
  • Added functions for EIP-1559 support and gas fee estimation

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.50704% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (9e3cbce) to head (bb8c2e7).

Files Patch % Lines
Thirdweb/Thirdweb.Utils/Utils.cs 89.83% 3 Missing and 3 partials ⚠️
...rdweb/Thirdweb.Transactions/ThirdwebTransaction.cs 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   82.71%   82.81%   +0.10%     
==========================================
  Files          25       25              
  Lines        3158     3218      +60     
  Branches      414      423       +9     
==========================================
+ Hits         2612     2665      +53     
- Misses        464      468       +4     
- Partials       82       85       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 0dd395e into main Aug 9, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/chain-utils branch August 9, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants