Add address field to EoaExecutorEvent and related structures

[d4mr]

• Introduced an address field in EoaExecutorEvent to capture the user's request address.
• Updated the EoaSendAttemptSuccessData structure to include the address.
• Modified event creation in various store implementations to populate the new address field from user requests.
• Enhanced webhook event handling to include address information for better tracking and reporting of transaction outcomes.

Summary by CodeRabbit

• New Features

  • Added an address field to various event notifications, providing more detailed information in transaction-related events.

• Improvements

  • Enhanced logging with additional nonce and transaction count metrics during transaction confirmation.
  • Confirm flow now proceeds even if no nonce progress is detected, improving reliability of transaction processing.

• Bug Fixes

  • Corrected log statements for consistency in variable naming.
  • Improved assignment of transaction receipt data for better accuracy.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce an address field to the EoaExecutorEvent struct and ensure it is populated throughout the event creation logic in various modules. A new struct, EoaSendAttemptSuccessData, is added to encapsulate both the submitted transaction and address for webhook notifications. Logging and control flow in the confirmation worker are also updated.

Changes

File(s)	Change Summary
executors/src/eoa/events.rs	Added address field to EoaExecutorEvent; introduced EoaSendAttemptSuccessData struct; updated method signatures and payload construction for success envelopes.
executors/src/eoa/store/atomic.rs	Populated the new address field in EoaExecutorEvent during transaction failure event creation.
executors/src/eoa/store/borrowed.rs	Set the address field in EoaExecutorEvent for submission result events (Success, Nack, Fail).
executors/src/eoa/store/submitted.rs	Added address field in EoaExecutorEvent for confirmed and replaced transaction events.
executors/src/eoa/worker/confirm.rs	Enhanced logging with cached_transaction_count; removed early return on nonce progress; updated receipt assignment.

Sequence Diagram(s)

sequenceDiagram
    participant Store
    participant EventBuilder
    participant Webhook

    Store->>EventBuilder: Create EoaExecutorEvent (with address)
    EventBuilder->>Webhook: send_attempt_success_envelope(submitted_transaction)
    Note right of EventBuilder: Wraps transaction + address in EoaSendAttemptSuccessData
    Webhook-->>EventBuilder: Notification with SerializableSuccessData<EoaSendAttemptSuccessData>

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 745dc10 and 5756503.

📒 Files selected for processing (1)

• executors/src/eoa/events.rs (4 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[joaquim-verges]

Can you make this eoa_address so it matches the 7702 one?