always fetch latest nonce for 7702 authorizations

[joaquim-verges]

Summary by CodeRabbit

• Bug Fixes

  • Improved reliability of transaction processing by ensuring the nonce is always fetched directly from the blockchain, reducing potential errors related to incorrect nonce values.

• New Features

  • Added clearer error reporting for nonce retrieval failures during transaction processing.

• Refactor

  • Simplified nonce handling by standardizing its type to a 64-bit unsigned integer throughout the authorization signing flow.

[coderabbitai]

Walkthrough

The changes update the nonce parameter in the authorization signing flow from a 256-bit integer to a 64-bit unsigned integer, simplifying nonce handling. In addition, the EIP-7702 executor now fetches the nonce asynchronously from the chain provider, introducing a new error variant for nonce fetch failures and encapsulating nonce retrieval in a helper function.

Changes

File(s)	Change Summary
core/src/signer.rs	Changed nonce parameter in AccountSigner and EoaSigner from U256 to u64; updated method logic accordingly.
executors/src/eip7702_executor/send.rs	Added NonceFetchError to Eip7702SendError; introduced get_eoa_nonce async function; updated process logic to fetch nonce asynchronously and handle errors.

Sequence Diagram(s)

sequenceDiagram
    participant Executor
    participant ChainProvider
    participant Signer

    Executor->>ChainProvider: get_eoa_nonce(address)
    ChainProvider-->>Executor: nonce (u64) or error
    alt Nonce fetch successful
        Executor->>Signer: sign_authorization(options, chain_id, address, nonce, credentials)
        Signer-->>Executor: SignedAuthorization
    else Nonce fetch error
        Executor-->>Executor: Handle NonceFetchError
    end

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f2daf1 and e10b920.

📒 Files selected for processing (2)

• core/src/signer.rs (2 hunks)
• executors/src/eip7702_executor/send.rs (3 hunks)

🔇 Additional comments (6)

executors/src/eip7702_executor/send.rs (3)

99-105: Good addition of specific error handling for nonce fetching.

The new NonceFetchError variant follows the established pattern of other error variants in the enum and provides proper error context for nonce fetch failures.

---

274-281: Improved nonce handling by always fetching from chain.

The change from using optional job data nonce to always fetching the latest nonce from the chain provider ensures consistency and prevents potential issues with stale nonces. The error handling properly wraps the helper function error into the new NonceFetchError variant.

---

528-542: Well-implemented helper function for nonce fetching.

The get_eoa_nonce function properly encapsulates the RPC call and error handling. The error mapping to EngineError::RpcError with appropriate context (chain_id, rpc_url, message) follows the established pattern in the codebase.

core/src/signer.rs (3)

197-197: Good simplification of nonce type in trait signature.

Changing the nonce parameter from U256 to u64 simplifies the interface and uses a more appropriate type for nonce values, which don't require the full 256-bit range.

---

358-358: Consistent implementation of simplified nonce type.

The parameter type change in the implementation matches the trait signature update, maintaining consistency.

---

365-365: Confirm rpc::types::Authorization.nonce is u64
The Authorization struct you’re assigning to comes from the external rpc crate—please double-check that its nonce field is indeed defined as u64, so this direct assignment is safe.

• File: core/src/signer.rs, around line 365

  let authorization = Authorization {
      nonce,
      // …
  };

• Action: Inspect the Authorization struct in the rpc crate (via its source or docs) and ensure nonce: u64.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.