Enhance error handling in EIP-7702 executor for transaction hash retr…

[d4mr]

…ieval

• Updated error handling logic to differentiate between error responses and other errors when fetching transaction hashes from the bundler.
• Improved the failure response mechanism by implementing specific handling for error responses, allowing for more granular control over job failures and retries.

These changes enhance the robustness of the EIP-7702 executor's error management during transaction hash retrieval.

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability when submitting transactions to the bundler. Permanent RPC errors now fail fast with clear feedback, while transient issues are automatically retried after a short delay. This reduces unnecessary retries, shortens time to definitive failure, and increases overall stability of transaction confirmations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Introduced conditional error handling when retrieving a bundler transaction hash: RPC error responses now trigger a permanent failure, while non-RPC errors trigger a 10-second nack retry. Added RpcError import to support error-type checks. Consolidated previous error-mapping paths into a single conditional map_err branch.

Changes

Cohort / File(s)	Change summary
Bundler tx-hash error handling executors/src/eip7702_executor/confirm.rs	Added RpcError import; replaced prior error mapping with conditional handling: RPC error responses lead to .fail(); other errors lead to .nack(10s, RequeuePosition::Last); propagated via ?.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Worker as Executor Worker
  participant Bundler as Bundler RPC

  Worker->>Bundler: Request transaction hash
  alt Success
    Bundler-->>Worker: txHash
    Note right of Worker: Proceed with confirmation flow
  else Error
    Bundler-->>Worker: Error e
    alt e is RPC error response
      Note over Worker: Mark as permanent failure
      Worker-->>Worker: wrap as TransactionHashError.fail()
    else Other error
      Note over Worker: Retry later (10s)
      Worker-->>Worker: wrap as TransactionHashError.nack(10s, Last)
    end
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3a2b65c and 59bf56a.

📒 Files selected for processing (1)

• executors/src/eip7702_executor/confirm.rs (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pb/7702-err-resp-handling

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.