Skip to content

Conversation

d4mr
Copy link
Member

@d4mr d4mr commented Sep 11, 2025

  • Updated the nack duration for work remaining to be conditional based on account type, setting it to 2 seconds for minimal accounts and 200 milliseconds for others. This change aims to enhance responsiveness in error handling and optimize transaction processing times.

Summary by CodeRabbit

  • Improvements

    • Adjusts task requeue delays based on account type, applying longer backoff for minimal accounts and shorter delays for others.
  • Performance

    • Delivers smoother throughput under load with more responsive processing when work remains.
  • Reliability

    • Reduces unnecessary retries and churn, easing potential rate-limit pressure through smarter retry spacing.

- Updated the nack duration for work remaining to be conditional based on account type, setting it to 2 seconds for minimal accounts and 200 milliseconds for others. This change aims to enhance responsiveness in error handling and optimize transaction processing times.
Copy link

coderabbitai bot commented Sep 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adjusts the requeue delay in the EOA worker: introduces a local delay based on is_minimal_account (2s for minimal accounts, 200ms otherwise) and applies it in map_err_nack when requeuing remaining work.

Changes

Cohort / File(s) Summary
EOA worker requeue delay adjustment
executors/src/eoa/worker/mod.rs
Added a local delay derived from is_minimal_account: Some(Duration::from_secs(2)) for minimal accounts, else Some(Duration::from_millis(200)). Replaced previous hard-coded 200ms in map_err_nack with the new delay. No public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9913fda and 6ace4c6.

📒 Files selected for processing (1)
  • executors/src/eoa/worker/mod.rs (1 hunks)
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pb/conditional-eoa-polling-rate

Comment @coderabbitai help to get the list of available commands and usage tips.

@d4mr d4mr merged commit ee80eb0 into main Sep 11, 2025
2 of 3 checks passed
@d4mr d4mr deleted the pb/conditional-eoa-polling-rate branch September 11, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant