update tx count: remove redunant write

[d4mr]

Summary by CodeRabbit

• Bug Fixes

  • Improved timing of transaction counter updates after submissions to reduce transient inconsistencies in status displays and notifications.

• Chores

  • Internal adjustments to processing flow; cleanup, replacement handling, metrics, and webhook notifications remain unchanged.
  • No action required from users.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The Redis pipeline step that advanced the last_transaction_count_key_name during CleanSubmittedTransactions within SafeRedisTransaction was removed (commented out). All other logic—cleanup, replacement handling, metrics emission, and webhook queuing—remains unchanged.

Changes

Cohort / File(s)	Summary
EOA submitted store (Redis pipeline update removed) executors/src/eoa/store/submitted.rs	Commented out the Redis pipeline that atomically advanced last_transaction_count_key_name during submitted tx processing; control flow now skips this in-flight increment while retaining cleanup, replacement handling, metrics, and webhook enqueueing.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as CleanSubmittedTransactions
  participant T as SafeRedisTransaction
  participant R as Redis
  participant M as Metrics
  participant W as WebhookQueue

  rect rgb(240,245,255)
  Note over C,T: BEFORE (previous flow)
  C->>T: begin()
  T->>R: fetch submitted txs
  T->>R: cleanup / replacements
  T->>R: pipeline: advance last_transaction_count_key_name
  T-->>C: commit
  C->>M: emit metrics
  C->>W: enqueue webhooks
  end

  rect rgb(245,255,240)
  Note over C,T: AFTER (current flow)
  C->>T: begin()
  T->>R: fetch submitted txs
  T->>R: cleanup / replacements
  Note over T,R: Skips advancing last_transaction_count_key_name
  T-->>C: commit
  C->>M: emit metrics
  C->>W: enqueue webhooks
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch pb/no-redundant-tx-count-increase

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b4487d0 and eb5a940.

📒 Files selected for processing (1)

• executors/src/eoa/store/submitted.rs (1 hunks)

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}