7702 cleanup

[joaquim-verges]

Summary by CodeRabbit

• New Features

  • Enhanced error reporting in transaction confirmation and sending processes, providing more detailed error context and distinguishing between different error types.
  • Added a new error variant to indicate when a transaction receipt is not yet available.

• Bug Fixes

  • Improved handling of optional transaction hashes and receipts, ensuring more accurate retry and error messaging behavior.

• Refactor

  • Updated address handling for increased type safety and removed redundant parsing.
  • Adjusted error propagation and reporting for clearer and more informative messages.
  • Modified JSON serialization of error fields to use camelCase for improved consistency in API responses.
  • Made transaction hash optionally returned when absent in responses.
  • Streamlined error handling in authorization signing by returning errors directly.
  • Added descriptive schema title for EIP-7702 execution options.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce enhanced error handling and type safety across several modules. Error variants in enums are extended to include optional inner errors for richer context, and a new error variant is added for transaction receipt unavailability. Address constants are now strongly typed, and serialization attributes are updated for consistent JSON output. Optionality is introduced for transaction hash responses.

Changes

File(s)	Change Summary
core/src/rpc_clients/bundler.rs	Made transaction_hash field in TwGetTransactionHashResponse optional, updated tw_get_transaction_hash return type to propagate this optionality.
core/src/signer.rs	Modified error propagation in sign_authorization to return the original error directly instead of wrapping it.
executors/src/eip7702_executor/confirm.rs	Enhanced Eip7702ConfirmationError with an optional inner_error field, added a ReceiptNotAvailable variant, adjusted error handling and retry logic, and shortened retry delays.
executors/src/eip7702_executor/send.rs	Changed address constant to a typed value, extended error variants to include optional inner errors, removed AuthorizationError variant, and simplified address handling.
executors/src/external_bundler/confirm.rs	Added #[serde(rename_all = "camelCase")] to each UserOpConfirmationError enum variant for consistent JSON field naming.
core/src/execution_options/eip7702.rs	Added #[schema(title = "EIP-7702 Execution Options")] attribute to the Eip7702ExecutionOptions struct for schema documentation.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BundlerClient
    participant BundlerService

    Client->>BundlerClient: tw_get_transaction_hash(transaction_id)
    BundlerClient->>BundlerService: Request transaction hash
    BundlerService-->>BundlerClient: { transaction_hash: Option<String> }
    BundlerClient-->>Client: TransportResult<Option<String>>

Loading

sequenceDiagram
    participant Executor
    participant Engine
    participant Blockchain

    Executor->>Engine: Request transaction hash
    alt Transaction hash error
        Engine-->>Executor: Error (TransactionHashError)
        Executor->>Executor: Retry with nack (5s)
    else Transaction hash is None
        Executor->>Executor: Return TransactionHashError, retry (5s)
    else Transaction hash found
        Executor->>Blockchain: Get transaction receipt
        alt Receipt not available
            Blockchain-->>Executor: None
            Executor->>Executor: Return ReceiptNotAvailable, retry (2s)
        else Receipt found
            Blockchain-->>Executor: Receipt
            Executor-->>Executor: Continue processing
        end
    end

Loading

sequenceDiagram
    participant Executor
    participant Signer

    Executor->>Signer: sign_authorization()
    alt Error occurs
        Signer-->>Executor: Error (propagated directly)
        Executor->>Executor: Attach as inner_error in SigningError
    else Success
        Signer-->>Executor: Signature
        Executor-->>Executor: Continue processing
    end

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0)

Updating crates.io index
Updating git repository `ssh://git@github.com/thirdweb-dev/vault.git`

error: failed to get vault-sdk as a dependency of package engine-aa-core v0.1.0 (/aa-core)

Caused by:
failed to load source for dependency vault-sdk

Caused by:
Unable to update ssh://git@github.com/thirdweb-dev/vault.git?branch=main#a9d62a85

Caused by:
failed to create directory /usr/local/git/db/vault-02bb070e2aa0045e

Caused by:
Permission denied (os error 13)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c2cee6 and 460a594.

📒 Files selected for processing (1)

• core/src/execution_options/eip7702.rs (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.