Skip to content

send receipts in 7702 success webhooks #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jul 7, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced transaction confirmation details by providing the full transaction receipt in confirmation results and error messages.
  • Bug Fixes

    • Improved accuracy and completeness of transaction failure information by including the entire receipt, ensuring users have all relevant data for troubleshooting.

Copy link

coderabbitai bot commented Jul 7, 2025

Walkthrough

The changes update the handling of transaction confirmation results by replacing individual receipt-related fields with a single TransactionReceipt object in both the result and error structures. This affects the Eip7702ConfirmationResult struct and the TransactionFailed error variant, consolidating receipt data management.

Changes

File(s) Change Summary
executors/src/eip7702_executor/confirm.rs Updated Eip7702ConfirmationResult to hold a TransactionReceipt instead of separate fields; modified TransactionFailed error variant to include the full receipt. Adjusted logic to pass/return the full receipt object.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant ConfirmModule
    participant Blockchain

    Caller->>ConfirmModule: process(transaction)
    ConfirmModule->>Blockchain: fetchReceipt(transaction)
    Blockchain-->>ConfirmModule: TransactionReceipt
    alt Receipt status is success
        ConfirmModule-->>Caller: Eip7702ConfirmationResult { receipt }
    else Receipt status is failure
        ConfirmModule-->>Caller: TransactionFailed { message, receipt }
    end
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0)
Updating crates.io index
Updating git repository `ssh://git@github.com/thirdweb-dev/vault.git`

error: failed to get vault-sdk as a dependency of package engine-aa-core v0.1.0 (/aa-core)

Caused by:
failed to load source for dependency vault-sdk

Caused by:
Unable to update ssh://git@github.com/thirdweb-dev/vault.git?branch=pb%2Fupdate-alloy#b0a72f93

Caused by:
failed to create directory /usr/local/git/db/vault-02bb070e2aa0045e

Caused by:
Permission denied (os error 13)


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca790e8 and 342884a.

📒 Files selected for processing (1)
  • executors/src/eip7702_executor/confirm.rs (5 hunks)
🔇 Additional comments (5)
executors/src/eip7702_executor/confirm.rs (5)

3-3: LGTM: Import addition is correct.

The import for TransactionReceipt is necessary for the consolidation changes and is correctly placed.


244-244: LGTM: Consistent implementation of receipt inclusion in errors.

The implementation correctly passes the full receipt object when creating the TransactionFailed error, providing complete transaction context for failure analysis.


259-259: LGTM: Consistent implementation of receipt inclusion in success results.

The implementation correctly passes the full receipt object in the success result, aligning with the PR objective to "send receipts in 7702 success webhooks".


86-89: No internal breakage from added receipt field on TransactionFailed

A repo-wide search for TransactionFailed only returned its definition and its single construction site in executors/src/eip7702_executor/confirm.rs. There are no other pattern matches or external usages in the codebase. Adding the receipt field is confined to this file and does not break internal error handling.


56-56: No remaining individual receipt field usages found
I searched for block_number, gas_used, and .status outside of TransactionReceipt and found no instances of the old, now-removed fields. This breaking change is fully contained within the executor API.

– Confirm you bump the crate’s major version to signal this public-API break.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joaquim-verges joaquim-verges merged commit 6be3247 into main Jul 7, 2025
3 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/receipt branch July 7, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant