Skip to content

Update to use tini in Dockerfile to propagate signals #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Update to use tini in Dockerfile to propagate signals #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e36c535
Update to use tini in Dockerfile to propagate signals
adam-maj Sep 27, 2023
43427f4
Update entrypoint in dev Dockerfile
adam-maj Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
FROM node:18.15.0-alpine AS base

# Install tini
RUN apk add --no-cache tini

# Set the working directory
WORKDIR /app

# Use tini as entrypoint to handle killing processes
ENTRYPOINT ["/sbin/tini", "--"]

# Install build dependencies
RUN apk --no-cache --virtual build-dependencies add g++ make py3-pip

Expand Down Expand Up @@ -38,6 +44,9 @@ CMD [ "yarn", "dev:worker" ]
# Production stage
FROM node:18.15.0-alpine AS prod

# Install tini
RUN apk add --no-cache tini

# Set the working directory
WORKDIR /app

Expand All @@ -61,4 +70,6 @@ RUN yarn install --production=true --frozen-lockfile --network-timeout 1000000
# Clean up build dependencies
RUN apk del build-dependencies

# Use tini as entrypoint to handle killing processes
ENTRYPOINT ["/sbin/tini", "--"]
CMD [ "yarn", "start"]