ERC20/721/1155 Signature Generate & Mint #47
Conversation
|
We're building your pull request over on Zeet. |
|
We're building your pull request over on Zeet. |
| to, | ||
| currencyAddress, | ||
| metadata, | ||
| mintEndTime, |
There was a problem hiding this comment.
I believe all these date types support only javascript date object (which wouldn't work well over HTTP) or unix timestamps, which is useable but not the most intuitive. Might be good to consider supporting date timestamps here if they don't work (worth looking into)
There was a problem hiding this comment.
the expected input data-type for mintEndTime & mintStartTime is Number as I am expecting a date-timestamp in milliseconds.
I will take a look
There was a problem hiding this comment.
@adam-maj I did update the datatype to be date-time which expects ISO 8601 date-time string, which devs can get using new Date().toISOString(). I think this what you were asking to do. plz let me know if this isn't what you meant
server/utilities/validator.ts
Outdated
| } | ||
|
|
||
| // givig 10 seconds of buffer | ||
| return new Date(value).getTime() >= Date.now() - 10 * 1000; |
There was a problem hiding this comment.
we don't need this as per feedback
Linear Ticket: PLAT-941