-
Notifications
You must be signed in to change notification settings - Fork 100
Added implementation to support deployed contract Address #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We're building your pull request over on Zeet. |
We're building your pull request over on Zeet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just need to add support for published contracts as well (not just prebuilts)
server/helpers/dbOperations.ts
Outdated
builder.where("txMined", false); | ||
builder.where("txErrored", false); | ||
} | ||
builder.where("extension", "deployer_prebuilt"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw we prob want to return deployed contracts via the published
endpoint too right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should. I will update it.
Do we also want the publish
end-point to have individual end-points too? like prebuilts?

and is there a way to get the contractType
(like edition
, edition-drop
etc, when using deployReleasedContract
? So that I can add this data to table for publish flow deployed contracts?
@@ -70,6 +70,7 @@ export async function deployPublished(fastify: FastifyInstance) { | |||
tx, | |||
network, | |||
"deployer_published", | |||
deployedAddress, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the deployedContractAddress
when using published
end-point. But need to find a way to find contractType
of the contract being deployed. So that table has this information captured
Added new end-point to allow to check for all deployed contract address via transactions.