Skip to content

Conversation

farhanW3
Copy link
Contributor

Added new end-point to allow to check for all deployed contract address via transactions.

@zeet-co
Copy link

zeet-co bot commented Jun 21, 2023

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://web3-api-akbv-farhan-plat-939.chainsaw-dev.zeet.app before merging 😉

@zeet-co
Copy link

zeet-co bot commented Jun 21, 2023

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://web3-api-7qzi-farhan-plat-939.zeet-nftlabs.zeet.app before merging 😉

Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just need to add support for published contracts as well (not just prebuilts)

builder.where("txMined", false);
builder.where("txErrored", false);
}
builder.where("extension", "deployer_prebuilt");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw we prob want to return deployed contracts via the published endpoint too right?

Copy link
Contributor Author

@farhanW3 farhanW3 Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it should. I will update it.

Do we also want the publish end-point to have individual end-points too? like prebuilts?

image

and is there a way to get the contractType (like edition, edition-drop etc, when using deployReleasedContract? So that I can add this data to table for publish flow deployed contracts?

@@ -70,6 +70,7 @@ export async function deployPublished(fastify: FastifyInstance) {
tx,
network,
"deployer_published",
deployedAddress,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the deployedContractAddress when using published end-point. But need to find a way to find contractType of the contract being deployed. So that table has this information captured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants