Skip to content

Conversation

iketw
Copy link
Contributor

@iketw iketw commented Aug 29, 2023

Problem solved

You can now do:

import { ThirdwebProvider, embeddedWallet } from "@thirdweb-dev/react-native";

<ThirdwebProvider
  clientId="your-client-id"
  supportedWallets={[embeddedWallet()]}
>
  <App />
</ThirdwebProvider>;

To use the embeddedWallet you need to add the following dependencies to your project:

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@iketw iketw requested a review from a team as a code owner August 29, 2023 20:02
@iketw iketw requested a review from a team August 29, 2023 20:02
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2023

🦋 Changeset detected

Latest commit: bc3160c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@thirdweb-dev/react-native-compat Patch
@thirdweb-dev/react-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@joaquim-verges
Copy link
Member

/release-pr

@iketw
Copy link
Contributor Author

iketw commented Sep 28, 2023

/release-pr

import { getAuthTokenClient } from "../storage/local";
import * as Application from "expo-application";

const EMBEDDED_WALLET_TOKEN_HEADER = "embedded-wallet-token";

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "embedded-wallet-token" is used as [authorization header](1).
@iketw
Copy link
Contributor Author

iketw commented Sep 29, 2023

/release-pr

@iketw iketw enabled auto-merge September 29, 2023 21:50
@iketw iketw added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 5dc372f Sep 29, 2023
@iketw iketw deleted the ike/paper branch September 29, 2023 21:56
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants