[SDK] Perf improvements with Promise.all

packages/sdk/src/evm/common/any-evm-utils/computeDeploymentInfo.ts

@@ -141,7 +141,7 @@ export async function encodeConstructorParamsForImplementation(
       return p.type;
     }
   });
-
+  const { chainId } = await provider.getNetwork();
   const constructorParamValues = await Promise.all(
     constructorParams.map(async (p) => {
       if (constructorParamMap && constructorParamMap[p.name]) {
@@ -200,7 +200,6 @@ export async function encodeConstructorParamsForImplementation(
 
         return deploymentInfo.transaction.predictedAddress;
       } else if (p.name && p.name.includes("royaltyEngineAddress")) {
-        const chainId = (await provider.getNetwork()).chainId;
         return getRoyaltyEngineV1ByChainId(chainId);
       } else if (p.name && p.name.includes("marketplaceV3Params")) {
         const chainId = (await provider.getNetwork()).chainId;

packages/sdk/src/evm/common/any-evm-utils/deployCreate2Factory.ts

@@ -27,9 +27,10 @@ export async function deployCreate2Factory(
   if (commonFactoryExists) {
     return COMMON_FACTORY;
   }
-
-  const enforceEip155 = await isEIP155Enforced(signer.provider);
-  const networkId = (await signer.provider.getNetwork()).chainId;
+  const [enforceEip155, { chainId: networkId }] = await Promise.all([
+    isEIP155Enforced(signer.provider),
+    signer.provider.getNetwork(),
+  ]);
   const chainId = enforceEip155 ? networkId : 0;
   console.debug(`ChainId ${networkId} enforces EIP155: ${enforceEip155}`);
   const deploymentInfo = CUSTOM_GAS_FOR_CHAIN[networkId]

packages/sdk/src/evm/common/any-evm-utils/getCreate2FactoryAddress.ts

@@ -23,9 +23,10 @@ export async function getCreate2FactoryAddress(
   if (commonFactoryExists) {
     return COMMON_FACTORY;
   }
-
-  const enforceEip155 = await isEIP155Enforced(provider);
-  const networkId = (await provider.getNetwork()).chainId;
+  const [enforceEip155, { chainId: networkId }] = await Promise.all([
+    isEIP155Enforced(provider),
+    provider.getNetwork(),
+  ]);
   const chainId = enforceEip155 ? networkId : 0;
   const deploymentInfo = CUSTOM_GAS_FOR_CHAIN[networkId]
     ? getCreate2FactoryDeploymentInfo(chainId, {

packages/sdk/src/evm/common/any-evm-utils/getEncodedConstructorParamsForThirdwebContract.ts

@@ -41,15 +41,12 @@ export async function getEncodedConstructorParamsForThirdwebContract(
     secretKey,
   );
   const publishUri = publishedContract.metadataUri;
-  const metadata = await fetchAndCacheDeployMetadata(publishUri, storage);
-  const create2Factory = await getCreate2FactoryAddress(provider);
+  const [metadata, create2Factory, { extendedMetadata }] = await Promise.all([
+    fetchAndCacheDeployMetadata(publishUri, storage),
+    getCreate2FactoryAddress(provider),
+    fetchAndCacheDeployMetadata(publishUri, storage),
+  ]);
   invariant(create2Factory, "Thirdweb stack not found");
-
-  const { extendedMetadata } = await fetchAndCacheDeployMetadata(
-    publishUri,
-    storage,
-  );
-
   let encodedArgs;
 
   // if pluginMetadata is not empty, then it's a plugin-pattern router contract

packages/sdk/src/evm/common/any-evm-utils/predictThirdwebContractAddress.ts

@@ -38,14 +38,11 @@ export async function predictThirdwebContractAddress(
     secretKey,
   );
   const publishUri = publishedContract.metadataUri;
-  const create2Factory = await getCreate2FactoryAddress(provider);
+  const [create2Factory, { extendedMetadata }] = await Promise.all([
+    getCreate2FactoryAddress(provider),
+    fetchAndCacheDeployMetadata(publishUri, storage),
+  ]);
   invariant(create2Factory, "Thirdweb stack not found");
-
-  const { extendedMetadata } = await fetchAndCacheDeployMetadata(
-    publishUri,
-    storage,
-  );
-
   if (
     extendedMetadata?.routerType === "plugin" ||
     extendedMetadata?.routerType === "dynamic"

packages/sdk/src/evm/common/deploy.ts

@@ -41,8 +41,10 @@ export async function getDeployArguments<
   signer: Signer,
   storage: ThirdwebStorage,
 ): Promise<any[]> {
-  const chainId = await signer.getChainId();
-  const signerAddress = await signer.getAddress();
+  const [chainId, signerAddress] = await Promise.all([
+    signer.getChainId(),
+    signer.getAddress(),
+  ]);
   const chainEnum = SUPPORTED_CHAIN_IDS.find((c) => c === chainId);
   let trustedForwarders: string[] = [];
   if (!chainEnum) {

packages/sdk/src/evm/common/verification.ts

@@ -64,23 +64,25 @@ export async function verifyThirdwebPrebuiltImplementation(
   secretKey?: string,
   constructorArgs?: ConstructorParamMap,
 ): Promise<string | string[]> {
-  const contractAddress = await getThirdwebContractAddress(
-    contractName,
-    chainId,
-    storage,
-    contractVersion,
-    clientId,
-    secretKey,
-  );
-  const encodedArgs = await getEncodedConstructorParamsForThirdwebContract(
-    contractName,
-    chainId,
-    storage,
-    contractVersion,
-    clientId,
-    secretKey,
-    constructorArgs,
-  );
+  const [contractAddress, encodedArgs] = await Promise.all([
+    getThirdwebContractAddress(
+      contractName,
+      chainId,
+      storage,
+      contractVersion,
+      clientId,
+      secretKey,
+    ),
+    getEncodedConstructorParamsForThirdwebContract(
+      contractName,
+      chainId,
+      storage,
+      contractVersion,
+      clientId,
+      secretKey,
+      constructorArgs,
+    ),
+  ]);
 
   console.info(`Verifying ${contractName} at address ${contractAddress}`);
 

packages/sdk/src/evm/contracts/prebuilt-implementations/marketplace.ts

@@ -596,17 +596,12 @@ export class Marketplace implements UpdateableNetwork {
   private async getAllListingsNoFilter(
     filterInvalidListings: boolean,
   ): Promise<(AuctionListing | DirectListing)[]> {
-    const listings = await Promise.all(
-      Array.from(
-        Array(
-          (await this.contractWrapper.read("totalListings", [])).toNumber(),
-        ).keys(),
-      ).map(async (i) => {
-        let listing;
-
-        try {
-          listing = await this.getListing(i);
-        } catch (err) {
+    const _totalListings = (
+      await this.contractWrapper.read("totalListings", [])
+    ).toNumber();
+    const _listings = await Promise.all(
+      Array.from(Array(_totalListings).keys()).map((i) =>
+        this.getListing(i).catch((err) => {
           if (err instanceof ListingNotFoundError) {
             return undefined;
           } else {
@@ -615,20 +610,29 @@ export class Marketplace implements UpdateableNetwork {
             );
             return undefined;
           }
-        }
-
-        if (listing.type === ListingType.Auction) {
-          return listing;
-        }
-
+        }),
+      ),
+    );
+    const _listingValidity = await Promise.all(
+      _listings.map((_listing) => {
+        if (!_listing || _listing === undefined) return { valid: false };
+        if (_listing.type === ListingType.Auction) return { valid: false };
+        if (filterInvalidListings)
+          return this.direct.isStillValidListing(_listing);
+        return { valid: false };
+      }),
+    );
+    const listings = await Promise.all(
+      _listings.map((_listing, index) => {
+        if (!_listing || _listing === undefined) return undefined;
+        if (_listing.type === ListingType.Auction) return _listing;
         if (filterInvalidListings) {
-          const { valid } = await this.direct.isStillValidListing(listing);
+          const { valid } = _listingValidity[index];
           if (!valid) {
             return undefined;
           }
         }
-
-        return listing;
+        return _listing;
       }),
     );
     return listings.filter((l) => l !== undefined) as (

packages/sdk/src/evm/core/classes/account-permissions.ts

@@ -434,18 +434,21 @@ export class AccountPermissions implements DetectableFeature {
       signerAddress: AddressOrEns,
       permissions: SignerPermissionsInput,
     ): Promise<Transaction> => {
-      const resolvedSignerAddress = await resolveAddress(signerAddress);
-      const resolvedPermissions = await SignerPermissionsSchema.parseAsync(
-        permissions,
-      );
-
-      if (await this.isAdmin(resolvedSignerAddress)) {
+      const [resolvedSignerAddress, resolvedPermissions] = await Promise.all([
+        resolveAddress(signerAddress),
+        SignerPermissionsSchema.parseAsync(permissions),
+      ]);
+      const [isAdmin, isSigner] = await Promise.all([
+        this.isAdmin(resolvedSignerAddress),
+        this.isSigner(resolvedSignerAddress),
+      ]);
+      if (isAdmin) {
         throw new Error(
           "Signer is already an admin. Cannot grant permissions to an existing admin.",
         );
       }
 
-      if (await this.isSigner(resolvedSignerAddress)) {
+      if (isSigner) {
         throw new Error(
           "Signer already has permissions. Cannot grant permissions to an existing signer. You can update permissions using `updatePermissions`.",
         );
@@ -480,18 +483,23 @@ export class AccountPermissions implements DetectableFeature {
       signerAddress: AddressOrEns,
       permissions: SignerPermissionsInput,
     ): Promise<Transaction> => {
-      const resolvedSignerAddress = await resolveAddress(signerAddress);
-      const resolvedPermissions = await SignerPermissionsSchema.parseAsync(
-        permissions,
-      );
+      const [resolvedSignerAddress, resolvedPermissions] = await Promise.all([
+        resolveAddress(signerAddress),
+        SignerPermissionsSchema.parseAsync(permissions),
+      ]);
+
+      const [isAdmin, isSigner] = await Promise.all([
+        this.isAdmin(resolvedSignerAddress),
+        this.isSigner(resolvedSignerAddress),
+      ]);
 
-      if (await this.isAdmin(resolvedSignerAddress)) {
+      if (isAdmin) {
         throw new Error(
           "Signer is already an admin. Cannot update permissions of an existing admin.",
         );
       }
 
-      if (!(await this.isSigner(resolvedSignerAddress))) {
+      if (!isSigner) {
         throw new Error(
           "Signer does not already have permissions. You can grant permissions using `grantPermissions`.",
         );
@@ -523,14 +531,17 @@ export class AccountPermissions implements DetectableFeature {
   revokeAccess = /* @__PURE__ */ buildTransactionFunction(
     async (signerAddress: AddressOrEns): Promise<Transaction> => {
       const resolvedSignerAddress = await resolveAddress(signerAddress);
-
-      if (await this.isAdmin(resolvedSignerAddress)) {
+      const [isAdmin, isSigner] = await Promise.all([
+        this.isAdmin(resolvedSignerAddress),
+        this.isSigner(resolvedSignerAddress),
+      ]);
+      if (isAdmin) {
         throw new Error(
           "Signer is already an admin. Cannot revoke permissions of an admin.",
         );
       }
 
-      if (!(await this.isSigner(resolvedSignerAddress))) {
+      if (!isSigner) {
         throw new Error(
           "Signer does not already have permissions. You can grant permissions using `grantPermissions`.",
         );
@@ -570,16 +581,21 @@ export class AccountPermissions implements DetectableFeature {
       signerAddress: AddressOrEns,
       target: AddressOrEns,
     ): Promise<Transaction> => {
-      const resolvedSignerAddress = await resolveAddress(signerAddress);
-      const resolvedTarget = await resolveAddress(target);
-
-      if (await this.isAdmin(resolvedSignerAddress)) {
+      const [resolvedSignerAddress, resolvedTarget] = await Promise.all([
+        resolveAddress(signerAddress),
+        resolveAddress(target),
+      ]);
+      const [isAdmin, isSigner] = await Promise.all([
+        this.isAdmin(resolvedSignerAddress),
+        this.isSigner(resolvedSignerAddress),
+      ]);
+      if (isAdmin) {
         throw new Error(
           "Signer is already an admin. Cannot approve targets for an admin.",
         );
       }
 
-      if (!(await this.isSigner(resolvedSignerAddress))) {
+      if (!isSigner) {
         throw new Error(
           "Signer does not already have permissions. You can grant permissions using `grantPermissions`.",
         );
@@ -631,16 +647,21 @@ export class AccountPermissions implements DetectableFeature {
       signerAddress: AddressOrEns,
       target: AddressOrEns,
     ): Promise<Transaction> => {
-      const resolvedSignerAddress = await resolveAddress(signerAddress);
-      const resolvedTarget = await resolveAddress(target);
-
-      if (await this.isAdmin(resolvedSignerAddress)) {
+      const [resolvedSignerAddress, resolvedTarget] = await Promise.all([
+        resolveAddress(signerAddress),
+        resolveAddress(target),
+      ]);
+      const [isAdmin, isSigner] = await Promise.all([
+        this.isAdmin(resolvedSignerAddress),
+        this.isSigner(resolvedSignerAddress),
+      ]);
+      if (isAdmin) {
         throw new Error(
           "Signer is already an admin. Cannot approve targets for an admin.",
         );
       }
 
-      if (!(await this.isSigner(resolvedSignerAddress))) {
+      if (!isSigner) {
         throw new Error(
           "Signer does not already have permissions. You can grant permissions using `grantPermissions`.",
         );
@@ -719,8 +740,12 @@ export class AccountPermissions implements DetectableFeature {
       const addOrUpdateSignerData: string[] = [];
       const removeSignerData: string[] = [];
 
+      const [allAdmins, allSigners] = await Promise.all([
+        this.getAllAdmins(),
+        this.getAllSigners(),
+      ]);
+
       // Remove all existing admins not included in the passed snapshot.
-      const allAdmins = await this.getAllAdmins();
       const allToMakeAdmin = resolvedSnapshot
         .filter((item) => item.makeAdmin)
         .map((item) => item.signer);
@@ -738,7 +763,6 @@ export class AccountPermissions implements DetectableFeature {
       });
 
       // Remove all existing signers not included in the passed snapshot.
-      const allSigners = await this.getAllSigners();
       const allToMakeSigners = resolvedSnapshot
         .filter((item) => {
           return !item.makeAdmin;
@@ -783,6 +807,19 @@ export class AccountPermissions implements DetectableFeature {
         }
       }
 
+      (
+        await Promise.all(
+          resolvedSnapshot
+            .filter((member) => !member.makeAdmin)
+            .map((member) =>
+              this.buildSignerPermissionRequest(
+                member.signer,
+                member.permissions,
+              ),
+            ),
+        )
+      ).map((data) => addOrUpdateSignerData.push(data));
+
       const data: string[] = [];
       removeAdminData.forEach((item) => {
         data.push(item);