Skip to content

Conversation

kien-ngo
Copy link
Contributor

Problem solved

This is a subset of the changes from the draft PR below. Since #1648 contains too many changes I will split it up into smaller PRs

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: ee077f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Minor
thirdweb Patch
@thirdweb-dev/react-core Major
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Major
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kien-ngo kien-ngo changed the title Code [SDK] Various improvement to data fetching in some erc721 modules Sep 27, 2023
@kien-ngo kien-ngo marked this pull request as ready for review September 27, 2023 02:27
@kien-ngo kien-ngo requested a review from a team September 27, 2023 02:27
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...sdk/src/evm/core/classes/erc-721-batch-mintable.ts 92.59% <100.00%> (-0.27%) ⬇️
...kages/sdk/src/evm/core/classes/erc-721-mintable.ts 83.87% <100.00%> (ø)
...ackages/sdk/src/evm/core/classes/erc-721-supply.ts 82.22% <100.00%> (+3.15%) ⬆️
packages/sdk/src/evm/core/classes/erc-721.ts 74.50% <100.00%> (+0.12%) ⬆️
...ckages/sdk/src/evm/functions/getContractFromAbi.ts 75.00% <100.00%> (ø)
...lasses/erc-721-with-quantity-signature-mintable.ts 91.01% <75.00%> (-0.10%) ⬇️

📢 Thoughts on this report? Let us know!.

@joaquim-verges joaquim-verges added this pull request to the merge queue Sep 27, 2023
@kien-ngo kien-ngo removed this pull request from the merge queue due to a manual request Sep 27, 2023
@kien-ngo kien-ngo added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit d28b1c0 Sep 27, 2023
@kien-ngo kien-ngo deleted the kien/concurrent branch September 27, 2023 14:25
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* Update AnnouncementBanner.tsx

* Fix prettier

---------

Co-authored-by: Nacho Iacovino <nacho.iacovino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants