Skip to content

Conversation

joaquim-verges
Copy link
Member

Problem solved

Expose resolveImplementation() helper function to resolve implementation address + bytecode of any proxy contract

Changes made

  • Public API changes: return type now returns implementation address as well
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@joaquim-verges joaquim-verges requested a review from a team September 27, 2023 14:33
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: ed3a71a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges joaquim-verges added this pull request to the merge queue Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...feature-detection/resolveContractUriFromAddress.ts 68.96% <66.66%> (ø)

... and 10 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Merged via the queue into main with commit a9b4b0c Sep 27, 2023
@joaquim-verges joaquim-verges deleted the joaquim/expose_impl_helper branch September 27, 2023 14:49
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant