Skip to content

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Oct 7, 2023

Problem solved

cc. #1648

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2023

🦋 Changeset detected

Latest commit: 3a2f6e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
packages/sdk/src/evm/common/nft.ts 67.24% <100.00%> (-0.56%) ⬇️
...evm/contracts/prebuilt-implementations/nft-drop.ts 86.91% <100.00%> (-0.13%) ⬇️
...ntracts/prebuilt-implementations/signature-drop.ts 86.59% <100.00%> (-0.14%) ⬇️

📢 Thoughts on this report? Let us know!.

@kien-ngo kien-ngo marked this pull request as ready for review October 7, 2023 12:21
@kien-ngo kien-ngo requested a review from a team October 7, 2023 12:21
@kien-ngo kien-ngo added this pull request to the merge queue Oct 7, 2023
Merged via the queue into main with commit 6abb845 Oct 7, 2023
@kien-ngo kien-ngo deleted the kien/nft-update branch October 7, 2023 12:28
@github-actions github-actions bot mentioned this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant