Skip to content

[SDK] Improve add/removeContract method for registry.ts #1731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2023
Merged

[SDK] Improve add/removeContract method for registry.ts #1731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33c5891
[SDK] Improve add/removeContract method for registry.ts
kien-ngo Oct 8, 2023
e408f5d
Merge branch 'main' into kien/kien_update_3
kien-ngo Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cuddly-gorillas-cheer.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/sdk": patch
---

Improve add/removeContract methods
24 changes: 8 additions & 16 deletions packages/sdk/src/evm/core/classes/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,11 @@ export class ContractRegistry extends ContractWrapper<TWRegistry> {
): Promise<Transaction<TransactionResult>> => {
const deployerAddress = await this.getSignerAddress();
const contractEncoder = new ContractEncoder(this);
const encoded: string[] = await Promise.all(
contractAddresses.map(async (address) =>
contractEncoder.encode("add", [
deployerAddress,
await resolveAddress(address),
]),
),
const encoded = (
await Promise.all(contractAddresses.map((addr) => resolveAddress(addr)))
).map((address) =>
contractEncoder.encode("add", [deployerAddress, address]),
);

return Transaction.fromContractWrapper({
contractWrapper: this,
method: "multicall",
Expand All @@ -79,15 +75,11 @@ export class ContractRegistry extends ContractWrapper<TWRegistry> {
): Promise<Transaction<TransactionResult>> => {
const deployerAddress = await this.getSignerAddress();
const contractEncoder = new ContractEncoder(this);
const encoded: string[] = await Promise.all(
contractAddresses.map(async (address) =>
contractEncoder.encode("remove", [
deployerAddress,
await resolveAddress(address),
]),
),
const encoded = (
await Promise.all(contractAddresses.map((addr) => resolveAddress(addr)))
).map((address) =>
contractEncoder.encode("remove", [deployerAddress, address]),
);

return Transaction.fromContractWrapper({
contractWrapper: this,
method: "multicall",
Expand Down