Skip to content

[SDK] Perf improv for drop-claim-conditions #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 13, 2023
Merged

[SDK] Perf improv for drop-claim-conditions #1762

merged 4 commits into from
Oct 13, 2023

Conversation

kien-ngo
Copy link
Contributor

Problem solved

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: eb53c14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kien-ngo kien-ngo changed the title Perf improv for drop-claim-conditions [SDK] Perf improv for drop-claim-conditions Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
.../sdk/src/evm/core/classes/drop-claim-conditions.ts 77.28% <100.00%> (-0.17%) ⬇️

📢 Thoughts on this report? Let us know!.

@kien-ngo
Copy link
Contributor Author

@joaquim-verges I'm working on improving the code for issue #1510 and as part of the PR #1648

Not sure why we are awaiting these "Read" function calls without using their results. Possible to remove?
Code location: https://github.com/thirdweb-dev/js/blob/main/packages/sdk/src/evm/core/classes/drop-claim-conditions.ts#L350-L378
image

@joaquim-verges
Copy link
Member

@kien-ngo we use them to check for errors, if they error out we show the corresponding ineligibility reasons

joaquim-verges
joaquim-verges approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@joaquim-verges joaquim-verges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@kien-ngo
Copy link
Contributor Author

Gotcha. Ty

@kien-ngo kien-ngo marked this pull request as ready for review October 13, 2023 22:53
@kien-ngo kien-ngo requested a review from a team October 13, 2023 22:53
@kien-ngo kien-ngo enabled auto-merge October 13, 2023 22:53
@kien-ngo kien-ngo added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 6573556 Oct 13, 2023
@kien-ngo kien-ngo deleted the kien/issue_1510 branch October 13, 2023 22:57
@github-actions github-actions bot mentioned this pull request Oct 13, 2023
Merged
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
@dependabot
bump eslint from 8.50.0 to 8.51.0 (#1762)
f79b0e8 
---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaquim-verges joaquim-verges joaquim-verges approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kien-ngo @joaquim-verges