Skip to content

[SDK] Perf improve to fetchPublishedContractFromPolygon() #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2023
Merged

[SDK] Perf improve to fetchPublishedContractFromPolygon() #1763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb19197
Update
kien-ngo Oct 14, 2023
cf75228
Merge branch 'main' into kien/chore_1
kien-ngo Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/friendly-suns-laugh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/sdk": patch
---

Improve fetchPublishedContractFromPolygon
24 changes: 12 additions & 12 deletions packages/sdk/src/evm/common/any-evm-utils/fetchPublishedContractFromPolygon.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,18 +50,18 @@ export async function fetchPublishedContractFromPolygon(
});

// get the metadata for each version
const versionMetadata = await Promise.all(
allVersions.map(async (c) => {
return {
name: c.id,
publishedTimestamp: c.timestamp,
publishedMetadata: await fetchAndCacheDeployMetadata(
c.metadataUri,
storage,
),
};
}),
);
const versionMetadata = (
await Promise.all(
allVersions.map((c) =>
fetchAndCacheDeployMetadata(c.metadataUri, storage),
),
)
).map((item, index) => ({
name: allVersions[index].id,
publishedTimestamp: allVersions[index].timestamp,
publishedMetadata: item,
}));

// find the version that matches the version string
const versionMatch = versionMetadata.find(
(metadata) =>
Expand Down