Skip to content

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 3, 2023

Problem solved

Avoid waterfalls in Promise.all
This is a continued work from #1648

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: 61483a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kien-ngo
Copy link
Contributor Author

kien-ngo commented Nov 3, 2023

Self note:To be improved:
image

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9187e0f) 68.03% compared to head (61483a8) 68.06%.
Report is 184 commits behind head on main.

Files Patch % Lines
...ackages/sdk/src/evm/core/classes/contract-roles.ts 71.42% 1 Missing and 1 partial ⚠️
...es/sdk/src/evm/core/classes/multichain-registry.ts 0.00% 2 Missing ⚠️
...vm/contracts/prebuilt-implementations/multiwrap.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1897      +/-   ##
==========================================
+ Coverage   68.03%   68.06%   +0.02%     
==========================================
  Files         291      291              
  Lines       10903    10918      +15     
  Branches     1488     1491       +3     
==========================================
+ Hits         7418     7431      +13     
- Misses       2866     2868       +2     
  Partials      619      619              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kien-ngo kien-ngo changed the title [SDK] Perf improv [SDK] Remove request waterfall from multiple methods Nov 3, 2023
@kien-ngo kien-ngo changed the title [SDK] Remove request waterfall from multiple methods [SDK] Perf improvement: Remove request waterfall from multiple methods Nov 3, 2023
@kien-ngo kien-ngo marked this pull request as ready for review November 3, 2023 05:59
@kien-ngo kien-ngo requested a review from a team November 3, 2023 05:59
@kien-ngo kien-ngo marked this pull request as draft November 4, 2023 04:31
@kien-ngo kien-ngo self-assigned this Nov 13, 2023
Copy link

stale bot commented Jan 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Won't Fix This will not be worked on. label Jan 12, 2024
@stale stale bot closed this Jan 19, 2024
@kien-ngo kien-ngo deleted the kien/pa branch March 25, 2024 12:10
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* edit images and og:image

* changes are made

* Link fixes to hero

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

---------

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>
Co-authored-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Won't Fix This will not be worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant