Skip to content

Conversation

warengonzaga
Copy link
Contributor

@warengonzaga warengonzaga commented Nov 16, 2023

Add Filipino Language Support

Credits to Filipino community members.

Kudos to the amazing community help from Web3 Philippines

@warengonzaga warengonzaga requested a review from a team November 16, 2023 15:02
Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: ee7d0b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@warengonzaga
Copy link
Contributor Author

Updated from fil into tl as per standard code.

@warengonzaga
Copy link
Contributor Author

Hey @iketw I'm still working on the update, please don't yet merge this.

@warengonzaga warengonzaga changed the title Add Filipino language to React Native Add Filipino language to React and React Native SDK Nov 24, 2023
@warengonzaga warengonzaga marked this pull request as draft November 24, 2023 16:23
@warengonzaga
Copy link
Contributor Author

Hey @iketw sorry for the delay, I'll find some time this week to finish this. Thanks!

@warengonzaga warengonzaga added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Dec 6, 2023
@warengonzaga warengonzaga marked this pull request as ready for review January 4, 2024 13:42
@warengonzaga warengonzaga requested a review from a team as a code owner January 4, 2024 13:42
@warengonzaga warengonzaga self-assigned this Jan 4, 2024
@warengonzaga warengonzaga added Enhancement An improvement on existing functionality with no modifications to the public API. and removed DO NOT MERGE This pull request is still in progress and is not ready to be merged. labels Jan 4, 2024
@warengonzaga
Copy link
Contributor Author

Hey @iketw I'm done with the translation for the React SDK kindly review it. Thank you for waiting!
Let me know if this is correct.

Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>
@jnsdls jnsdls enabled auto-merge January 11, 2024 07:59
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnsdls
Copy link
Member

jnsdls commented Jan 11, 2024

hey @warengonzaga sorry for the long delay here, it looks like since you created this new strings to translate were added in /react - could you check the object of strings for completeness (and update the necessary new strings) and then we can get this merged

@jnsdls jnsdls disabled auto-merge January 11, 2024 08:09
@warengonzaga
Copy link
Contributor Author

hey @warengonzaga sorry for the long delay here, it looks like since you created this new strings to translate were added in /react - could you check the object of strings for completeness (and update the necessary new strings) and then we can get this merged

I'm able to find the missing string, pushed the changes.

@jnsdls jnsdls enabled auto-merge January 11, 2024 08:45
@jnsdls jnsdls disabled auto-merge January 11, 2024 08:59
@jnsdls jnsdls enabled auto-merge January 11, 2024 09:22
@jnsdls jnsdls added this pull request to the merge queue Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (3cb53c4) 67.50% compared to head (ee7d0b5) 67.08%.
Report is 4 commits behind head on main.

Files Patch % Lines
...evm/core/classes/internal/erc721/erc-721-supply.ts 60.00% 0 Missing and 2 partials ⚠️
packages/sdk/src/evm/core/classes/erc-721.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
- Coverage   67.50%   67.08%   -0.43%     
==========================================
  Files         291      291              
  Lines       11017    11016       -1     
  Branches     1513     1513              
==========================================
- Hits         7437     7390      -47     
- Misses       2955     3001      +46     
  Partials      625      625              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into thirdweb-dev:main with commit 5d56700 Jan 11, 2024
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement An improvement on existing functionality with no modifications to the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants