-
Notifications
You must be signed in to change notification settings - Fork 585
Add Filipino language to React and React Native SDK #1964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ee7d0b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Updated from |
Hey @iketw I'm still working on the update, please don't yet merge this. |
Hey @iketw sorry for the delay, I'll find some time this week to finish this. Thanks! |
Hey @iketw I'm done with the translation for the React SDK kindly review it. Thank you for waiting! |
Signed-off-by: Jonas Daniels <jonas.daniels@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hey @warengonzaga sorry for the long delay here, it looks like since you created this new strings to translate were added in |
I'm able to find the missing string, pushed the changes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1964 +/- ##
==========================================
- Coverage 67.50% 67.08% -0.43%
==========================================
Files 291 291
Lines 11017 11016 -1
Branches 1513 1513
==========================================
- Hits 7437 7390 -47
- Misses 2955 3001 +46
Partials 625 625 ☔ View full report in Codecov by Sentry. |
Add Filipino Language Support
Credits to Filipino community members.
Kudos to the amazing community help from Web3 Philippines