Enforce react-hooks/exhaustive-deps lint rule #2138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d643efb The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@IDubuque Can you verify that the useEffect deps changes I have made in this PR do not add unwanted side-effects? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2138 +/- ##
=======================================
Coverage 67.50% 67.50%
=======================================
Files 291 291
Lines 11017 11017
Branches 1513 1513
=======================================
Hits 7437 7437
Misses 2955 2955
Partials 625 625 ☔ View full report in Codecov by Sentry. |
jnsdls
added
the
DO NOT MERGE
|
waiting on @IDubuque review |
jnsdls
reviewed
Jan 11, 2024
| @@ -36,7 +36,7 @@ export const Modal: React.FC<{ | |||
| return () => { | |||
| document.removeEventListener("keydown", keyDownHandler); | |||
| }; | |||
| }, []); | |||
| }, [escapeToClose, onClose]); | |||
| @@ -84,7 +84,7 @@ export const VerifyOwnershipWithPaper: React.FC< | |||
| return () => { | |||
| window.removeEventListener("message", handleMessage); | |||
| }; | |||
| }, []); | |||
| }, [onError, onSuccess, onWindowClose]); | |||
| @@ -141,7 +141,7 @@ export const PaperCheckout = <T extends ContractType>({ | |||
| return () => { | |||
| window.removeEventListener("message", handleMessage); | |||
| }; | |||
| }, []); | |||
| }, [onCloseCheckout, onPaymentSuccess, onTransferSuccess]); | |||
Comment on lines
+101
to
+112
| appNameToUse, | ||
| clientId, | ||
| configs, | ||
| locale, | ||
| onBeforeModalOpen, | ||
| onCardDetailLoad, | ||
| onError, | ||
| onPaymentSuccess, | ||
| onPriceUpdate, | ||
| onReview, | ||
| options, | ||
| sdkClientSecret, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
react-hooks/exhaustive-depslint rule is not followed - throw error insteadreact-hooks/exhaustive-depsissues in payments components